linux-kernel - [PATCH] spi: two bug-fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Jun 2008 17:11:14 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@...gutronix.de>
To:	linux-kernel@...r.kernel.org
cc:	dbrownell@...rs.sourceforge.net
Subject: [PATCH] spi: two bug-fixes

Two SPI-related fixes: unsigned int cannot be less than zero, and the list
search success check is wrong: for example, it didn't recognise failure for me
when I requested port 0.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@...gutronix.de>

---

It might be a good idea to get it in for 2.6.26. As a side note I was 
surprised, that the compiler didn't generate a warning for "if (t<0)" for 
unsigned t, whereas it does generate one for unsigned char with the same 
flags (-Wall). I asked on gcc, there was one reply from Segher 
Boessenkool, it is unclear if this is going to be recognised as a bug or 
not: http://gcc.gnu.org/ml/gcc/2008-06/threads.html#00044

 arch/arm/mach-pxa/ssp.c |    2 +-
 drivers/gpio/mcp23s08.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/gpio/mcp23s08.c
===================================================================
--- linux-2.6.orig/drivers/gpio/mcp23s08.c	2008-06-04 12:11:26.000000000 +0200
+++ linux-2.6/drivers/gpio/mcp23s08.c	2008-06-04 12:11:50.000000000 +0200
@@ -178,7 +178,7 @@
 
 	mutex_lock(&mcp->lock);
 	t = mcp23s08_read_regs(mcp, 0, mcp->cache, sizeof mcp->cache);
-	if (t < 0) {
+	if ((int)t < 0) {
 		seq_printf(s, " I/O ERROR %d\n", t);
 		goto done;
 	}
Index: linux-2.6/arch/arm/mach-pxa/ssp.c
===================================================================
--- linux-2.6.orig/arch/arm/mach-pxa/ssp.c	2008-06-04 12:11:26.000000000 +0200
+++ linux-2.6/arch/arm/mach-pxa/ssp.c	2008-06-04 12:11:50.000000000 +0200
@@ -330,7 +330,7 @@
 
 	mutex_unlock(&ssp_lock);
 
-	if (ssp->port_id != port)
+	if (&ssp->node == &ssp_list)
 		return NULL;
 
 	return ssp;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/