linux-kernel - Compiler warning in v2.6.26-rc4-213-ge97dcb0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48470ED2.6030307@lwfinger.net>
Date:	Wed, 04 Jun 2008 16:53:22 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Compiler warning in v2.6.26-rc4-213-ge97dcb0

With the version given in the subject, I get the following warning:

   CC      drivers/serial/serial_core.o
drivers/serial/serial_core.c:2300: warning: initialization from incompatible 
pointer type

The problem arises in commit 64e9159f5d2c which has uart_set_ldisc as follows:

static void uart_set_ldisc(struct tty_struct *tty, int ldisc)

The set_ldisc routine has only one argument:

        void            (*set_ldisc)(struct uart_port *);

I think this additional patch fixes the problem:

Index: linux-2.6/drivers/serial/serial_core.c
===================================================================
--- linux-2.6.orig/drivers/serial/serial_core.c
+++ linux-2.6/drivers/serial/serial_core.c
@@ -1165,7 +1165,7 @@ out:
         return ret;
  }

-static void uart_set_ldisc(struct tty_struct *tty, int ldisc)
+static void uart_set_ldisc(struct tty_struct *tty)
  {
         struct uart_state *state = tty->driver_data;
         struct uart_port *port = state->port;


Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/