lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Jun 2008 22:54:52 -0400 From: Patrick McManus <mcmanus@...ksong.com> To: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> Cc: David Miller <davem@...emloft.net>, mingo@...e.hu, peterz@...radead.org, LKML <linux-kernel@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, rjw@...k.pl, Andrew Morton <akpm@...ux-foundation.org>, johnpol@....mipt.ru Subject: Re: [fixed] [patch] Re: [bug] stuck localhost TCP connections, v2.6.26-rc3+ On Wed, 2008-06-04 at 02:22 +0300, Ilpo Järvinen wrote: == > -- > [PATCH] tcp DEFER_ACCEPT: fix racy access to listen_sk > > It seems that replacement of DA code also moved parts outside > of appropriate locking. The Ingo's problem seems to come from > the fact that two flows could now race in > (inet_csk_)reqsk_queue_add corrupting the queue. ...This can > leave dangling socks around which won't resolve themselves > without stimuli from outside (e.g., external RST would help > I think). Ilpo, has anyone told you today that you rock? Well allow me - you rock. > do_rcv() clearly has the listening socket locked in the non-DA case, and in the DA case it is the 'child' ESTABLISHED socket that is locked - leaving the accept queue unprotected. So simple. -Pat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists