linux-kernel - Re: [PATCH] x86: e820 max_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48471B68.3050103@zytor.com>
Date:	Wed, 04 Jun 2008 15:47:04 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: e820 max_arch_pfn typo fix for 64 bit

Yinghai Lu wrote:
> should use right shift
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
> 
> Index: linux-2.6/arch/x86/kernel/e820.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/e820.c
> +++ linux-2.6/arch/x86/kernel/e820.c
> @@ -771,7 +771,7 @@ u64 __init early_reserve_e820(u64 startt
>  #  define MAX_ARCH_PFN		(1ULL<<(32-PAGE_SHIFT))
>  # endif
>  #else /* CONFIG_X86_32 */
> -# define MAX_ARCH_PFN MAXMEM<<PAGE_SHIFT
> +# define MAX_ARCH_PFN MAXMEM>>PAGE_SHIFT
>  #endif
>  

Should also use parens (operator inside a macro).

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/