linux-kernel - Re: [parch 3/4] vfs: utimensat(): fix error checking for {UTIME_NOW,UTIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1K3l1W-0007ia-Vc@pomaz-ex.szeredi.hu>
Date:	Wed, 04 Jun 2008 06:54:58 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	mtk.manpages@...glemail.com
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	hch@....de, miklos@...redi.hu, viro@...iv.linux.org.uk,
	jamie@...reable.org, drepper@...hat.com,
	linux-fsdevel@...r.kernel.org, subrata@...ux.vnet.ibm.com
Subject: Re: [parch 3/4] vfs: utimensat(): fix error checking for {UTIME_NOW,UTIME_OMIT}
 case

> > +	} else if ((times[0].tv_nsec == UTIME_NOW &&
> > +		    times[1].tv_nsec == UTIME_OMIT)
> > +		  ||
> > +		   (times[0].tv_nsec == UTIME_OMIT &&
> > +		    times[1].tv_nsec == UTIME_NOW)) {
> 

> +
> +		if (!is_owner_or_cap(inode))
> +			goto mnt_drop_write_and_out;

And in fact a little comment wouldn't hurt explaining what exactly is
going on here with the permission checking.

The "/* Don't worry, the checks are done in inode_change_ok() */" is
really reassuring, but unfortunately not exactly the truth (and never
was).

Miklos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/