linux-kernel - Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4847B415.2080708@cam.ac.uk>
Date:	Thu, 05 Jun 2008 10:38:29 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	Éric Piel <Eric.Piel@...mplin-utc.net>,
	Andrew Morton <akpm@...l.org>,
	Torokhov <dmitry.torokhov@...il.com>,
	Burman <burman.yan@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	HWMON <lm-sensors@...sensors.org>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Pavel Machek <pavel@...e.cz>, Yan@...pms.net,
	Dmitry@...pms.net, Arjan van de Ven <arjan@...radead.org>
Subject: Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection
 System 3D ACPI driver -- please review!

Jean Delvare wrote:
> On Thu, 05 Jun 2008 01:43:46 +0200, Éric Piel wrote:
>> 05-06-08 01:05, Pavel Machek wrote/a écrit:
>>>> So my advice is that you don't wait for a review from the hwmon people,
>>>> because apparently we don't have much interest in this type of device,
>>>> so you'll be waiting forever. You're much better adding the mdps driver
>>>> to drivers/misc through Andrew Morton, at least until someone takes
>>>> care of creating a subsystem for this type of devices and move all
>>>> existing drivers there.
>>> Just create drivers/accel ... accelerometers are quite common these
>>> days. Going to drivers/misc is okay, too, I guess -- moves are easy
>>> with git ;-).
>> Yes, why not do one little step to the correct direction now and create
>> drivers/accel, it will likely be the chosen name anyway! That will not
>> yet be a "real" subsystem, just a place to put all the related drivers
>> already present together.
> 
> Well, I would expect all these accelerometer drivers to have a common,
> standardized interface, so this should most probably become a real
> subsystem in the long run.
> 
>> Anyone against this idea?
> 
> I am in favor of it.
The upshot of the discussion Jean referenced was that the there were a 
number of other devices / sensors that will form part of the same system.

For an initial bash I'm throwing in a couple of accelerometers, ADC's and
probably one or two other sensors as well.  Haven't come up with a good
name as yet, but the point is that accelerometers would be just part of
the relevant subsystem.

Based on one suggestion (and current layout in my source tree), 
drivers/industrialio/accelerometer
drivers/industrialio/adc
and crucially for all those weird and wonderful sensors,
drivers/industrialio/misc

The reason for making it an io system is that many chips combine ADCs and
DACs.  Also suggestions for alternative names would be most welcome.

Still, it may take some time to iron out the various kinks in this system
and get it fully tested, so may be worth putting stuff elsewhere for now
with the intention to move it as and when the more unified stuff has been
written.

Also, the LI3L02DQ (very similar to the chip you are using) is one of my
test chips, so combining the two drivers should be straight forward.
Also the driver I have is SPI only, so this may give us an easy way to
test a combined driver.

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/