linux-kernel - Re: [PATCH] fsl_usb2_udc: Add a wmb before priming endpoint.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a5b0800806050500pa48f081j75fa58e696ed8cc8@mail.gmail.com>
Date:	Thu, 5 Jun 2008 13:00:03 +0100
From:	"Will Newton" <will.newton@...il.com>
To:	me@...ipebalbi.com
Cc:	linux-usb@...r.kernel.org,
	"Linux Kernel list" <linux-kernel@...r.kernel.org>,
	leoli@...escale.com
Subject: Re: [PATCH] fsl_usb2_udc: Add a wmb before priming endpoint.

On Tue, Jun 3, 2008 at 6:24 PM, Felipe Balbi <me@...ipebalbi.com> wrote:
> On Tue, Jun 03, 2008 at 04:20:25PM +0100, Will Newton wrote:
>> Add a wmb to fsl_queue_td before priming the endpoint. This ensures that the
>> modifications to the QH are seen by the hardware.
>>
>> Signed-off-by: Will Newton <will.newton@...il.com>
>> ---
>>  drivers/usb/gadget/fsl_usb2_udc.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/fsl_usb2_udc.c
>> b/drivers/usb/gadget/fsl_usb2_udc.c
>> index 1868754..dd06a5b 100644
>> --- a/drivers/usb/gadget/fsl_usb2_udc.c
>> +++ b/drivers/usb/gadget/fsl_usb2_udc.c
>> @@ -653,6 +653,8 @@ static int fsl_queue_td(struct fsl_ep *ep, struct
>> fsl_req *req)
>>                       | EP_QUEUE_HEAD_STATUS_HALT));
>>       dQH->size_ioc_int_sts &= temp;
>>
>> +     wmb();
>
> checkpatch.pl will complain that there's not comment above the memory
> barrier. Could you just add it and in one line summarize why wmb()??

Yes, I'll do that and resend the patch along with the rest of the series I have.

My checkpatch does not seem to complain about the missing comment btw.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/