linux-kernel - [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_user instead of put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ca0a85e0806050804q4c164105uc386dcae2ccd21d@mail.gmail.com>
Date:	Thu, 5 Jun 2008 11:04:21 -0400
From:	"Thomas Tuttle" <ttuttle@...gle.com>
To:	mpm@...enic.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 1/5] pagemap: Modify add_to_pagemap to use copy_to_user instead of put_user.

While fiddling with pagemap, I discovered a bug in add_to_pagemap.
When it is copying an entry that is not at the end of the buffer, it
uses put_user to copy a u64 into a char* buffer.  The problem is that
put_user determines how much to copy based on the size of the
*destination*, not the source, so it only copied one byte.  To fix
this, I replaced the call to put_user with a call to copy_to_user, as
is used when copying the last (possibly partial) PFN into the buffer.

View attachment "0001-Modified-add_to_pagemap-to-use-copy_to_user-instead.patch" of type "text/x-patch" (866 bytes)