linux-kernel - Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ca0a85e0806050905j6cf33f3dx9143333aa0a8b6e7@mail.gmail.com>
Date:	Thu, 5 Jun 2008 12:05:51 -0400
From:	"Thomas Tuttle" <ttuttle@...gle.com>
To:	"Matt Mackall" <mpm@...enic.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] pagemap: Make pagemap_read enforce reading in multiples of 8

On Thu, Jun 5, 2008 at 12:03 PM, Matt Mackall <mpm@...enic.com> wrote:
>
> On Thu, 2008-06-05 at 11:06 -0400, Thomas Tuttle wrote:
>> Since kpagecount and kpageflags require reads in multiples of 8, and
>> it simplifies add_to_pagemap significantly, I added the same
>> requirement to /proc/pid/pagemap.
>
> I'm generally fine with this. Another approach that's perhaps more
> friendly is when someone tries to do a 24-byte read, do a 16-byte read,
> leaving the file pointer aligned. Not sure if that's completely kosher
> though.

This doesn't require that they read exactly 8 bytes, just that they
read some multiple of 8 bytes.  (They can read 8, 16, 24, etc..., just
not something like 12.)

--ttuttle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/