linux-kernel - Re: [PATCH 1/2] devscgroup: check for device permissions at mount time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080605154956.GC11919@us.ibm.com>
Date:	Thu, 5 Jun 2008 10:49:57 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Serge Hallyn <serue@...ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] devscgroup: check for device permissions at mount
	time

Quoting Pavel Emelyanov (xemul@...nvz.org):
> Currently even if a task sits in an all-denied cgroup it can still 
> mount any block device in any mode it wants.
> 
> Put a proper check in do_open for block device to prevent this.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Crud.  Tested and confirmed, and this patches fixes it.

Acked-by: Serge Hallyn <serue@...ibm.com>
Tested-by: Serge Hallyn <serue@...ibm.com>

thanks,
-serge

> ---
>  fs/block_dev.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index a0e9596..7e1c7a3 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -24,6 +24,7 @@
>  #include <linux/namei.h>
>  #include <linux/log2.h>
>  #include <linux/hardirq.h>
> +#include <linux/device_cgroup.h>
> 
>  #include <asm/uaccess.h>
>  #include "internal.h"
> @@ -933,9 +934,14 @@ static int do_open(struct block_device *bdev, struct file *file, int for_part)
>  {
>  	struct module *owner = NULL;
>  	struct gendisk *disk;
> -	int ret = -ENXIO;
> +	int ret;
>  	int part;
> 
> +	ret = devcgroup_inode_permission(bdev->bd_inode, file->f_mode);
> +	if (ret != 0)
> +		return ret;
> +
> +	ret = -ENXIO;
>  	file->f_mapping = bdev->bd_inode->i_mapping;
>  	lock_kernel();
>  	disk = get_gendisk(bdev->bd_dev, &part);
> -- 
> 1.5.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/