linux-kernel - Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40806051118y39cbf14fye5268c819d4bbbfc@mail.gmail.com>
Date:	Thu, 5 Jun 2008 12:18:56 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	avorontsov@...mvista.com
Cc:	"Pierre Ossman" <drzeus-mmc@...eus.cx>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	"Jochen Friedrich" <jochen@...am.de>,
	"Segher Boessenkool" <segher@...nel.crashing.org>,
	"Gary Jennejohn" <garyj@...x.de>,
	"Guennadi Liakhovetski" <g.liakhovetski@....de>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

On Thu, Jun 5, 2008 at 12:00 PM, Anton Vorontsov
<avorontsov@...mvista.com> wrote:
> On Thu, Jun 05, 2008 at 11:36:09AM -0600, Grant Likely wrote:
>> On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov
>> <avorontsov@...mvista.com> wrote:
>> > Well, I mentioned the usb_add_hcd()-alike approach for the mmc_spi
>> > host... The absence of enthusiasm I equaled to "no".
>> >
>> > Heh.
>>
>> I'm allergic to USB HCD code; I was probably having convulsions under my desk.
>
> :-)
>
> Ok, I also mentioned drivers/ata/pata_of_platform.c (OF version is using
> common code from drivers/ata/pata_platform.c).
>
> Please look there, and tell me if this is what you have in mind. (ignore
> _probe in the __pata_platform_probe name. Imagine
> pata_platform_add_controller or something).

Yes, I like that.  I've done something very similar for drivers with
both of and non-of bindings.  For another example, this time all
contained within a single .c file, see drivers/video/xilinxfb.c

>> > p.s.
>> > Btw, you forgot another downside of v2 approach: struct spi_driver
>> > duplication... Not sure if everyone will be happy about it.
>> >
>> > Though, v2 is only version where we can make modular OF_MMC_SPI.
>>
>> I think we've got our wires crossed.  I'm not referring to the option
>> of an of_mmc_spi driver registering an mmc_spi device (which can then
>> be probed by the mmc_spi_driver).
>
> I'm not refrering to this option either.

Okay, I'm confused then.  Where is the duplication of struct spi_driver?

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/