linux-kernel - Re: [PATCH 3/4] pagemap: Return EINVAL, not EIO, for unaligned reads of kpagecount or kpageflags (v2 of series)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1212691757.3953.191.camel@calx>
Date:	Thu, 05 Jun 2008 13:49:17 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	Thomas Tuttle <ttuttle@...gle.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] pagemap: Return EINVAL, not EIO, for unaligned
	reads of kpagecount or kpageflags (v2 of series)


On Thu, 2008-06-05 at 14:40 -0400, Thomas Tuttle wrote:
> If the user tries to read from a position that is not a multiple of 8, or
> read a number of bytes that is not a multiple of 8, they have passed an
> invalid argument to read, for the purpose of reading these files.  It's
> not an IO error because we didn't encounter any trouble finding the data
> they asked for.

Hmm. I seem to recall choosing EIO because that's what unaligned reads
with direct I/O report. I don't particularly care though.

Acked-by: Matt Mackall <mpm@...enic.com>

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/