linux-kernel - Re: [PATCH] FRV: ip_fast_csum() requires a memory clobber on its inline asm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080605185744.GA30405@parisc-linux.org>
Date:	Thu, 5 Jun 2008 12:57:45 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FRV: ip_fast_csum() requires a memory clobber on its inline asm

On Thu, Jun 05, 2008 at 05:07:35PM +0100, David Howells wrote:
>  	    : "=r" (sum), "=r" (iph), "=r" (ihl), "=r" (inc), "=&r"(tmp)
>  	    : "0" (sum), "1" (iph), "2" (ihl), "3" (4),
>  	    "m"(*(volatile struct { int _[100]; } *)iph)

Do you still need the input "m" constraint?

> -	    : "icc0", "icc1"
> +	    : "icc0", "icc1", "memory"
>  	    );
>  
>  	return (__force __sum16)~sum;

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/