linux-kernel - Re: [PATCH] fix build bug in "x86: add PCI extended config space access for AMD Barcelona"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806052239110.3235@apollo.tec.linutronix.de>
Date:	Thu, 5 Jun 2008 22:41:26 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Robert Richter <robert.richter@....com>
cc:	Ingo Molnar <mingo@...e.hu>, Yinghai Lu <yhlu.kernel@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] fix build bug in "x86: add PCI extended config space
 access for AMD Barcelona"

On Thu, 5 Jun 2008, Robert Richter wrote:
> --- a/include/asm-x86/mmconfig.h
> +++ b/include/asm-x86/mmconfig.h
> @@ -9,10 +9,4 @@ static inline void fam10h_check_enable_mmcfg(void) { }
>  static inline void check_enable_amd_mmconf_dmi(void) { }
>  #endif
>  
> -#if defined(CONFIG_SMP) && defined(CONFIG_X86_64)
> -extern void __cpuinit amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c);
> -#else
> -static inline void amd_enable_pci_ext_cfg(struct cpuinfo_x86 *c) { }
> -#endif
> -

Can we please remove this superflous arch/x86/kernel/setup.h file,
which has a length/content ratio of 26:1. This removes the ugly
"../setup.h" includes

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/