linux-kernel - Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806052245530.3235@apollo.tec.linutronix.de>
Date:	Thu, 5 Jun 2008 22:49:38 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Andres Salomon <dilinger@...ued.net>, linux-kernel@...r.kernel.org,
	mingo@...hat.com, hpa@...or.com, rmh@...abtu.com,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] OLPC: pci: fix up PCI stuff so that PCI_GOANY supports
 OLPC

On Thu, 5 Jun 2008, Andrew Morton wrote:
> On Thu, 5 Jun 2008 15:29:14 -0400
> Andres Salomon <dilinger@...ued.net> wrote:
> 
> > Previously, one would have to specifically choose CONFIG_OLPC and
> > CONFIG_PCI_GOOLPC in order to enable PCI_OLPC.  That doesn't really
> > work for distro kernels, so this patch allows one to choose
> > CONFIG_OLPC and CONFIG_PCI_GOANY in order to build in OLPC support in
> > a generic kernel (as requested by Robert Millan).
> > 
> > This also moves GOOLPC before GOANY in the menuconfig list.
> > 
> > Finally, make pci_access_init return early if we detect OLPC hardware.
> > There's no need to continue probing stuff, and pci_pcbios_init
> > specifically trashes our settings (we didn't run into that before
> > because PCI_GOANY wasn't supported).
> > 
> > It would be great if we could sneak this in for 2.6.26..  *cough*  :)
> > 
> 
> It looks harmless enough.
> 
> > ---
> >  arch/x86/Kconfig    |   11 +++++------
> >  arch/x86/pci/init.c |    3 ++-
> >  arch/x86/pci/olpc.c |    5 +++--
> >  arch/x86/pci/pci.h  |    2 +-
> 
> But I never know whether arch/x86/pci is a Jesse thing or an Ingo
> thing.  Usual answer: it's an everyone thing and we all make a big mess ;)

So the Salomonic solution is: 

You pick it up and send it either to Jesse or x86@...nel.org :)

I put it into my urgent bucket just to be on the safe side.

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/