linux-kernel - Re: [PATCH -mm 11/14] bootmem: respect goal more likely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Jun 2008 17:31:50 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	Johannes Weiner <hannes@...urebad.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 11/14] bootmem: respect goal more likely


I gotcha!  :-)

 	max -= PFN_DOWN(bdata->node_boot_start);
 	start -= PFN_DOWN(bdata->node_boot_start);
+	fallback -= PFN_DOWN(bdata->node_boot_start);
 
 	if (bdata->last_success > start) {
-		/* Set goal here to trigger a retry on failure */
-		start = goal = ALIGN(bdata->last_success, step);
+		fallback = start; -------------------------------- (*)
+		start = ALIGN(bdata->last_success, step);
 	}

(*) is root cause. "fallback" is set as 0, because start is index of bitmap
at here. When normal zone is allocated first, and DMA zone is required by
alloc_bootmem_low() later and first page is free yet, fallback is set as 0.

+	if (fallback) {
+		start = ALIGN(fallback, step);
+		fallback = 0;
+		goto find_block;
+	}
+

As a result, this retry code is skipped, and alloc_bootmem_low() fails. 
So, when I change here from fallback to a retry_flag, my box can boot up.

Thanks.
-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/