linux-kernel - Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection System 3D ACPI driver -- please review!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2008 10:24:53 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Pau Oliva Fora <pau@...ack.org>
Cc:	?ric Piel <Eric.Piel@...mplin-utc.net>,
	Jonathan Cameron <jic23@....ac.uk>,
	Jean Delvare <khali@...ux-fr.org>,
	Andrew Morton <akpm@...l.org>, Burman <burman.yan@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	HWMON <lm-sensors@...sensors.org>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Pavel Machek <pavel@...e.cz>, Yan@...pms.net,
	Dmitry@...pms.net, Arjan van de Ven <arjan@...radead.org>
Subject: Re: [lm-sensors] [PATCH 2.6.25.4] hwmon: HP Mobile Data Protection
	System 3D ACPI driver -- please review!

Hi,

On Fri, Jun 06, 2008 at 12:27:10AM +0200, Pau Oliva Fora wrote:
> From: Pau Oliva Fora <pau@...ack.org>
>
> Add support for HTC Shift UMPC G-Sensor LIS3LV02DL accelerometer.
>
> Signed-off-by: Pau Oliva Fora <pau@...ack.org>
>

The input piece looks good, however it seens that the input is the
only functionality that this driver exports so I don't see any reason
to make input device registration optional. Or are you planning on
adding more functions to it?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/