linux-kernel - Re: [intel-agp] Rewrite GTT on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080606135015.3f42820d.akpm@linux-foundation.org>
Date:	Fri, 6 Jun 2008 13:50:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Keith Packard <keithp@...thp.com>
Cc:	linux-kernel@...r.kernel.org, airlied@...ux.ie, keithp@...thp.com
Subject: Re: [intel-agp] Rewrite GTT on resume

On Tue, 03 Jun 2008 20:41:20 -0700
Keith Packard <keithp@...thp.com> wrote:

> On my Intel chipset (965GM), the GTT is entirely erased across
> suspend/resume. This patch simply re-plays the current mapping at resume
> time to restore the table. 
> 
> I noticed this once I started relying on persistent GTT mappings across
> VT switch in our GEM work -- the old X server and DRM code carefully
> unbind all memory from the GTT on VT switch, but GEM does not bother.
> 
> I placed the list management and rewrite code in the generic layer on
> the assumption that it will be needed on other hardware, but I did not
> add the rewrite call to anything other than the Intel resume function.
> 
> 
> commit 1233057731935fb5e9fd115d3d2985802ab636c8
> Author: Keith Packard <keithp@...thp.com>
> Date:   Tue Jun 3 20:34:54 2008 -0700
> 
>     [INTEL-AGP] Re-write GATT on resume
>     
>     Keep a list of current GATT mappings. At resume time, rewrite them into the
>     GATT. This is needed on Intel (at least) as the entire GATT is cleared
>     across suspend/resume.

Please send a signed-off-by:?

> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h
> index c69f795..253f56f 100644
> --- a/drivers/char/agp/agp.h
> +++ b/drivers/char/agp/agp.h
> @@ -148,6 +148,8 @@ struct agp_bridge_data {
>  	char minor_version;
>  	struct list_head list;
>  	u32 apbase_config;
> +	/* list of agp_memory mapped to the aperture */
> +	struct list_head mapped_list;
>  };

Is it safe to use this without locking?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/