| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200806062339.13418.david-b@pacbell.net>
Date: Fri, 6 Jun 2008 23:39:13 -0700
From: David Brownell <david-b@...bell.net>
To: "Andrew Victor" <avictor.za@...il.com>
Cc: linux-arm-kernel@...ts.arm.linux.org.uk, akpm@...ux-foundation.org,
wim@...ana.be, Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: AT91SAM9/CAP9 watchdog driver
I thought I'd finally get around to trying this driver.
No luck.
The proximate cause is that Atmel's second stage "at91boot"
loader disables the watchdog. That's because the reset state
of this watchdog is "reset after 16 seconds" ... so it must
be tended carefully until the Linux "watchdog" daemon takes
over. Since there's no code in at91boot, U-Boot, or Linux to
do that, it gets disabled. (How was this driver tested??)
Needless to say, this isn't exactly my model of how to make
a useful watchdog. That "write once" rule is pure trouble.
I suggest merging the following patch, to reduce confusion.
- Dave
======== CUT HERE
The at91sam9 watchdog is a kind of annoying bit of hardware: since its
mode register is write-once, it can't be reconfigured. Moreover, Atmel's
standard second stage loader "at91boot" always this watchdog (at least
on Atmel's reference boards), ensuring that Linux normally can't use it.
This patch removes some confusion by not registering the watchdog device
on systems where it was disabled before Linux starts.
Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
--- a/arch/arm/mach-at91/at91sam9260_devices.c 2008-06-06 15:00:06.000000000 -0700
+++ b/arch/arm/mach-at91/at91sam9260_devices.c 2008-06-06 20:40:38.000000000 -0700
@@ -21,6 +21,7 @@
#include <asm/arch/at91sam9260.h>
#include <asm/arch/at91sam9260_matrix.h>
#include <asm/arch/at91sam9_smc.h>
+#include <asm/arch/at91_wdt.h>
#include "generic.h"
@@ -666,6 +667,9 @@ static struct platform_device at91sam926
static void __init at91_add_device_watchdog(void)
{
+ /* WDT_MR is write-once; if it was disabled, we're stuck */
+ if (at91_sys_read(AT91_WDT_MR) & AT91_WDT_WDDIS)
+ return;
platform_device_register(&at91sam9260_wdt_device);
}
#else
--- a/arch/arm/mach-at91/at91sam9261_devices.c 2008-06-06 15:00:06.000000000 -0700
+++ b/arch/arm/mach-at91/at91sam9261_devices.c 2008-06-06 20:40:45.000000000 -0700
@@ -25,6 +25,7 @@
#include <asm/arch/at91sam9261.h>
#include <asm/arch/at91sam9261_matrix.h>
#include <asm/arch/at91sam9_smc.h>
+#include <asm/arch/at91_wdt.h>
#include "generic.h"
@@ -654,6 +655,9 @@ static struct platform_device at91sam926
static void __init at91_add_device_watchdog(void)
{
+ /* WDT_MR is write-once; if it was disabled, we're stuck */
+ if (at91_sys_read(AT91_WDT_MR) & AT91_WDT_WDDIS)
+ return;
platform_device_register(&at91sam9261_wdt_device);
}
#else
--- a/arch/arm/mach-at91/at91sam9263_devices.c 2008-06-06 15:00:06.000000000 -0700
+++ b/arch/arm/mach-at91/at91sam9263_devices.c 2008-06-06 20:40:48.000000000 -0700
@@ -24,6 +24,7 @@
#include <asm/arch/at91sam9263.h>
#include <asm/arch/at91sam9263_matrix.h>
#include <asm/arch/at91sam9_smc.h>
+#include <asm/arch/at91_wdt.h>
#include "generic.h"
@@ -911,6 +912,9 @@ static struct platform_device at91sam926
static void __init at91_add_device_watchdog(void)
{
+ /* WDT_MR is write-once; if it was disabled, we're stuck */
+ if (at91_sys_read(AT91_WDT_MR) & AT91_WDT_WDDIS)
+ return;
platform_device_register(&at91sam9263_wdt_device);
}
#else
--- a/arch/arm/mach-at91/at91sam9rl_devices.c 2008-06-06 15:00:06.000000000 -0700
+++ b/arch/arm/mach-at91/at91sam9rl_devices.c 2008-06-06 20:40:52.000000000 -0700
@@ -21,6 +21,7 @@
#include <asm/arch/at91sam9rl.h>
#include <asm/arch/at91sam9rl_matrix.h>
#include <asm/arch/at91sam9_smc.h>
+#include <asm/arch/at91_wdt.h>
#include "generic.h"
@@ -501,6 +502,9 @@ static struct platform_device at91sam9rl
static void __init at91_add_device_watchdog(void)
{
+ /* WDT_MR is write-once; if it was disabled, we're stuck */
+ if (at91_sys_read(AT91_WDT_MR) & AT91_WDT_WDDIS)
+ return;
platform_device_register(&at91sam9rl_wdt_device);
}
#else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists