linux-kernel - Re: [PATCH -mm 02/25] Use an indexed array for LRU variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080607104740.6c12a324@bree.surriel.com>
Date:	Sat, 7 Jun 2008 10:47:40 -0400
From:	Rik van Riel <riel@...hat.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	lee.schermerhorn@...com, clameter@....com
Subject: Re: [PATCH -mm 02/25] Use an indexed array for LRU variables

On Sat, 07 Jun 2008 14:43:50 +0900
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> > > Index: linux-2.6.26-rc2-mm1/include/linux/mm_inline.h
> > > ===================================================================
> > > --- linux-2.6.26-rc2-mm1.orig/include/linux/mm_inline.h	2008-05-23 14:21:21.000000000 -0400
> > > +++ linux-2.6.26-rc2-mm1/include/linux/mm_inline.h	2008-05-23 14:21:33.000000000 -0400
> > > @@ -1,40 +1,51 @@
> > >  static inline void
> > > +add_page_to_lru_list(struct zone *zone, struct page *page, enum lru_list l)
> > > +{
> > > +	list_add(&page->lru, &zone->list[l]);
> > > +	__inc_zone_state(zone, NR_INACTIVE + l);
> > 
> >                                ^ that's a bug, isn't it?
> 
> this is definitely bug.

I believe this is correct, actually.   I will rename/alias it to
VMSCAN_BASE or something along those lines.

> > oh, no it isn't.
> > Can we rename NR_INACTIVE?  Maybe VMSCAN_BASE or something?
> 
> as far as i remembered, old version use LRU_INACTIVE. 

LRU_* is used to index LRU arrays.

NR_* is used as an offset into the zone state.

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/