linux-kernel - Re: [PATCH v2] Add backlight driver for Nvidia-based Apple Macbook Pros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tzg5tiay.fsf@sonic.technologeek.org>
Date:	Sat, 07 Jun 2008 16:45:41 +0200
From:	Julien BLACHE <jb@...ache.org>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, rpurdie@...ys.net,
	linux-kernel@...r.kernel.org, mzxreary@...inter.de
Subject: Re: [PATCH v2] Add backlight driver for Nvidia-based Apple Macbook Pros

Matthew Garrett <mjg59@...f.ucam.org> wrote:

Hi,

> Signed-off-by: Matthew Garrett <mjg@...hat.com>

If you need it, here you have it:

 Signed-off-by: Julien Blache <jb@...ache.org>

Minor nitpicks follow:

> +config BACKLIGHT_MBP_NVIDIA
> +       tristate "Macbook Pro Nvidia Backlight Driver"
                    ^^^^^^^   
Proper capitalization is "MacBook", also to be consistent with other
help texts in the kernel (I hope).

> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.

This particular file in pommed is GPL v2 or later; it's external
code I included in pommed and the original license was GPL v2 or
later.

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb@...ache.org>                                  GPG KeyID 0xF5D65169
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/