linux-kernel - Re: [PATCH 4/8] atmel_nand: Clean up and fix probe() error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd73a99e0806070908n5c9b6be4ned0386905555a1b7@mail.gmail.com>
Date:	Sat, 7 Jun 2008 18:08:07 +0200
From:	"Andrew Victor" <avictor.za@...il.com>
To:	"Haavard Skinnemoen" <haavard.skinnemoen@...el.com>
Cc:	linux-mtd@...ts.infradead.org, kernel@...32linux.org,
	"Nicolas Ferre" <nicolas.ferre@...el.com>,
	"Patrice VILCHEZ" <patrice.vilchez@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] atmel_nand: Clean up and fix probe() error path

hi Haavard,

> This fixes several bugs in the atmel_nand_probe() error path, including
> at least one memory leak.

There is an issue with the current at91_nand driver here.

The driver currently ioremap()'s the ECC controller's registers, but
on the AT91 the ECC controller is part of the System Peripherals and
so it is already mapped at startup.
I don't think it can/should be remapped twice.

The AT91 patch (on maxim.org.za) current does:
    regs = platform_get_resource(pdev, IORESOURCE_MEM, 1);
         ....
    host->ecc = (void __force __iomem *) (AT91_VA_BASE_SYS - AT91_BASE_SYS);
    host->ecc += regs->start;
instead of the ioremap().  But this is not portable to the AVR32.


Regards,
  Andrew Victor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/