Message-ID: <dd18b0c30806071335j200daa9t517bf41ab10b2f@mail.gmail.com>
Date:	Sat, 7 Jun 2008 20:35:39 +0000
From:	"Justin Mattock" <justinmattock@...il.com>
To:	"Alexey Starikovskiy" <astarikovskiy@...e.de>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: ACPI: EC: GPE storm detected, disabling EC GPE

On Sat, Jun 7, 2008 at 7:28 PM, Alexey Starikovskiy
<astarikovskiy@...e.de> wrote:
> Justin Mattock wrote:
>>
>> On Sat, Jun 7, 2008 at 6:55 AM, Andrew Morton <akpm@...ux-foundation.org>
>> wrote:
>>>
>>> On Sat, 7 Jun 2008 06:21:54 +0000 "Justin Mattock"
>>> <justinmattock@...il.com> wrote:
>>>
>>>> Well; I was hoping it was going to be just an easy fix, but
>>>> unfortunately
>>>> changing
>>>>  if (atomic_read(&ec->irq_count) > 5) {
>>>>  to
>>>> if (atomic_read(&ec->irq_count) > 20) {
>>>> does seem to make the message disappear, for a while, probably at
>>>> around three hours,(for me at least) then the message appeared again.
>>>> :-(
>>>> So leaving me back to the beginning of try to have a go at this.
>>>> regards;
>>>
>>> I removed bugzilla from cc - that only works if there's [Bug 1234] in
>>> the Subject:.
>>>
>>> I added linux-acpi to cc - this is an acpi problem.
>>>
>>> What Justin is mysteriously referring to here is:
>>>
>>>
>>> : From: "Justin Mattock" <justinmattock@...il.com>
>>> : To: "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
>>> : Cc: "Rafael J. Wysocki" <rjw@...k.pl>
>>> : Subject: GPE storm detected, disabling EC GPE
>>> : Date:         Thu, 5 Jun 2008 21:01:55 +0000
>>> : Sender: linux-kernel-owner@...r.kernel.org
>>> :
>>> : FWIW I noticed a post where the person had changed 5 to 20, and it
>>> : seemed to work for them;
>>> : So with that in mind I decide to give that a go, here is the location:
>>> : drivers/acpi/ec.c
>>> : @@ -527,47 +488,51 @@ static u32 acpi_ec_gpe_handler(void *data)
>>> :  {
>>> :         acpi_status status = AE_OK;
>>> :         struct acpi_ec *ec = data;
>>> :        u8 state = acpi_ec_read_status(ec);
>>> :
>>> :         pr_debug(PREFIX "~~~> interrupt\n");
>>> :        atomic_inc(&ec->irq_count);
>>> : -       if (atomic_read(&ec->irq_count) > 5) {
>>> : +       if (atomic_read(&ec->irq_count) > 20) {
>>> :                pr_err(PREFIX "GPE storm detected, disabling EC GPE\n");
>>> :                ec_switch_to_poll_mode(ec);
>>> :                goto end;
>>> :        }
>>> :
>>> : Now I don't know if this will work for other brands, but for
>>> : me(Macbook Pro ATI chipset) I have not received the
>>> : GPE storm detected, disabling EC GPE message, but it's only been an
>>> : hour, maybe after two or three this might appear.
>>> : Also is this good or bad to set 5 to 20 for the system?
>>>
>>> Could someone from acpi land please help here?
>>>
>>> Justin, has this machine always had this problem or is it something
>>> which earlier kernels handled correctly?
>>>
>>> Thanks.
>>>
>>
>> This issue just recently started, 2.6.25-rc9 and below don't give me
>> this message.
>>
> Yes, the problem which we are fighting here is that almost all Acer
> notebooks come with
> broken EC. It sends interrupts not regarding the fact that we already ACKed
> it.
> It comes unnoticed on almost all machines (some notice laggy keyboard,
> because it's the same controller after all and it's busy with sending ACPI
> interrupts and then providing same status byte over and over), but on some
> machines keystrokes become missing, which is not tolerable (#9998).
> Acer technical support does not care about the issue as they don't support
> Linux on these machines,
> and Windows seems to be fine.
> There is a similar bug report #10724, with two suggested patches, which
> should increase a threshold of stray interrupts before we shutdown them and
> switch to poll mode.
>
> Regards,
> Alex.
>
>
>
>
>
>
>
>

Interesting, over here I'm using a Macbook Pro ATI chipset. I'm not
experiencing things like missing keys or anything of that nature.
but am concerned with what might happen to the hardware in the long
run. As for the patches I did apply those,
and it did give me a better idea of what is happening., but just to
get a right info, when ACPI: EC: gpe storm detected message appears
does it disable interrupt mode for that moment and then go back to it
original state, or is it once the gpe storm is triggered the interupt
mode is disabled until a reboot is performed. from looking at the data
from the patches that I used from here it looks like something in the
system triggers that message, but then after a few seconds  goes back
to its original state, until another storm is detected.
I don't have a problem with this message if it's triggering and then
returning to it's original state until another storm triggers this
message again, but I am concerned with the message being triggered,
and then the system is stuck in that mode until a reboot.(but if this
is O.K. for the system then that's cool too).
regards;

-- 
Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists