linux-kernel - Re: [linux-cifs-client] [PATCH] cifs: fix oops on mount when CONFIG_CIFS_DFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <524f69650806081316q219271e1qf33034a2a5463b28@mail.gmail.com>
Date:	Sun, 8 Jun 2008 15:16:38 -0500
From:	"Steve French" <smfrench@...il.com>
To:	"Q (Igor Mammedov)" <niallain@...il.com>
Cc:	"Marcin Slusarz" <marcin.slusarz@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Steve French" <sfrench@...ba.org>,
	linux-cifs-client@...ts.samba.org, stable@...nel.org
Subject: Re: [linux-cifs-client] [PATCH] cifs: fix oops on mount when CONFIG_CIFS_DFS_UPCALL is enabled

I have not tried this code path recently and mount.cifs should always
be filling in the data field (with at least one mount option) but in a
case where the mount helper is missing, and the UNC name is of the
form //ip_address_of_server/share_name then I would prefer that we
treat this case (no mount options specified) as:
1) userid is \0 (null user)
2) null password
3) server id address comes from the beginning of the UNC name
(required or we fail)
The rest of the parms are at their defaults:
e.g. sec=ntlm  (for smb2 this will be ntlmv2, and perhaps we should
change the default for cifs as well)

On Sun, Jun 8, 2008 at 6:28 AM, Q (Igor Mammedov) <niallain@...il.com> wrote:
> A quick look trough cifs_mount and cifs_parse_mount_options functions shows
> that mount will fail anyway with error EINVAL when 'data' = NULL.
> May be moving NULL check at the beginning of function will be better
> in this case.
>

-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/