linux-kernel - Re: [intel-agp] Rewrite GTT on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080608071302.GA4739@ucw.cz>
Date:	Sun, 8 Jun 2008 09:13:03 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Keith Packard <keithp@...thp.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, airlied@...ux.ie,
	Keith Packard <keith@...thp.com>
Subject: Re: [intel-agp] Rewrite GTT on resume

Hi!

> From 26b58f13ecbe95a7eaca7434aeb885def057b835 Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp@...thp.com>
> Date: Tue, 3 Jun 2008 20:34:54 -0700
> Subject: [PATCH] [INTEL-AGP] Re-write GATT on resume
> 
> Keep a list of current GATT mappings. At resume time, rewrite them into the
> GATT. This is needed on Intel (at least) as the entire GATT is cleared
> across suspend/resume. The list is protected by a spinlock.

Is this needed in case of iommu enabled, agp disabled, too?

> diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
> index eeea50a..7f1a96e 100644
> --- a/drivers/char/agp/intel-agp.c
> +++ b/drivers/char/agp/intel-agp.c
> @@ -2176,6 +2176,7 @@ static void __devexit agp_intel_remove(struct pci_dev *pdev)
>  static int agp_intel_resume(struct pci_dev *pdev)
>  {
>  	struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
> +	int ret_val;
>  
>  	pci_restore_state(pdev);
>  
> @@ -2203,6 +2204,10 @@ static int agp_intel_resume(struct pci_dev *pdev)
>  	else if (bridge->driver == &intel_i965_driver)
>  		intel_i915_configure();
>  
> +	ret_val = agp_rebind_memory();
> +	if (ret_val != 0)
> +		return ret_val;
> +
>  	return 0;
>  }
>  #endif

Should this move early (sysdev?) because other drivers may depend on
iommu working?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/