[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080609231037.b8aa7561.sfr@canb.auug.org.au>
Date: Mon, 9 Jun 2008 23:10:37 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Julia Lawall <julia@...u.dk>
Cc: benh@...nel.crashing.org, linuxppc-dev@...abs.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 4/4] drivers/macintosh/therm_adt746x.c: add missing
of_node_put
On Mon, 9 Jun 2008 14:21:51 +0200 (CEST) Julia Lawall <julia@...u.dk> wrote:
>
> From: Julia Lawall <julia@...u.dk>
>
> of_node_put is needed before discarding a value received from
> of_find_node_by_name, eg in error handling code.
>
> The semantic patch that makes the change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> struct device_node *n;
> struct device_node *n1;
> statement S;
> identifier f;
> expression E;
> constant C;
> @@
>
> n = of_find_node_by_name(...)
> ...
> if (!n) S
> ... when != of_node_put(n)
> when != n1 = f(n,...)
> when != E = n
> when any
> when strict
> (
> + of_node_put(n);
> return -C;
> |
> of_node_put(n);
> |
> n1 = f(n,...)
> |
> E = n
> |
> return ...;
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@...u.dk>
Acked-by: Stephen Rothwell <sfr@...b.auug.org.au>
--
Cheers,
Stephen Rothwell sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists