linux-kernel - Re: [PATCH 2/4] drivers/macintosh/smu.c: add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080609233201.fc638cc7.sfr@canb.auug.org.au>
Date:	Mon, 9 Jun 2008 23:32:01 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Julia Lawall <julia@...u.dk>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH 2/4] drivers/macintosh/smu.c: add missing of_node_put

Hi Julia,

On Mon, 9 Jun 2008 15:22:53 +0200 (CEST) Julia Lawall <julia@...u.dk> wrote:
>
> > However, the error handling in that routine (smu_init) needs much more
> > work.
> 
> Indeed, the smu = NULL at the end of the function seems a bit brutal - a 
> lot of allocated data ends up not getting freed.  I can try to do 
> something about it.  Did you see something else?

There are paths to fail: where you would need to of_node_put smu->db_node or
smu->msg_node (or both) and undo the smu->db_buf ioremap.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped