linux-kernel - Re: [PATCH] vmallocinfo: Add NUMA informations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0806090717370.29723@schroedinger.engr.sgi.com>
Date:	Mon, 9 Jun 2008 07:19:16 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Eric Dumazet <dada1@...mosbay.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	kosaki.motohiro@...fujitsu.com, nickpiggin@...oo.com.au,
	hugh@...itas.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vmallocinfo: Add NUMA informations

On Wed, 4 Jun 2008, Eric Dumazet wrote:

> -	return seq_open(file, &vmalloc_op);
> +	unsigned int *ptr = NULL;
> +	int ret;
> +
> +	if (NUMA_BUILD)
> +		ptr = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL);

Maybe a bit of overkill here. nr_node_ids == 1 in the !NUMA case which 
should not do much harm if you alloc the struct anymore.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/