linux-kernel - Re: Linux 2.6.26-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806082139.45829.bjorn.helgaas@hp.com>
Date:	Sun, 8 Jun 2008 21:39:45 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Frans Pop <elendil@...net.nl>
Cc:	Jesper Krogh <jesper@...gh.cc>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Avuton Olrich <avuton@...il.com>
Subject: Re: Linux 2.6.26-rc5

On Saturday 07 June 2008 3:50:59 pm Frans Pop wrote:
> Jesper Krogh wrote:
> > Not that they seem critical to the system but I do get alot of these. I
> > cant remember having seen that before.
> >
> > [    2.904467] system 00:06: iomem range 0x0-0x0 could not be reserved
> > [    2.904469] system 00:06: iomem range 0x0-0x0 could not be reserved
> > [    2.904471] system 00:06: iomem range 0x0-0x0 could not be reserved
> > [    2.904473] system 00:06: iomem range 0x0-0x0 could not be reserved
>
> [...]
>
> I'm getting these too. Not present in the last -rc4 kernel I built.
>
> Reverting this commit (the only recent one to the file the message
> originates from), gets rid of the extra zero-range messages:
>
> commit 4b34fe156455d26ee6ed67b61539f136bf4e439c
> Author: Bjorn Helgaas <bjorn.helgaas@...com>
> Date:   Mon Jun 2 16:42:49 2008 -0600
>
>     PNP: mark resources that conflict with PCI devices "disabled"
>
>     Both the PNP/PCI conflict detection quirk and the PNP system
>     driver must use the same mechanism to mark resources as disabled.
>
>     I think it's best to keep the resource and to keep the type bit
>     (IORESOURCE_MEM, etc), so that we match the list from firmware
>     as closely as possible.
>
>     Fixes this regression from 2.6.25: http://lkml.org/lkml/2008/6/1/82
>
>     Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>
>     Tested-by: Avuton Olrich <avuton@...il.com>
>     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
>
> Relevant CCs added.

The patch below should fix this and is already in Linus' tree.
Can you give it a whirl to confirm?  Thanks!


PNP: skip UNSET MEM resources as well as DISABLED ones

We don't need to reserve "unset" resources.  Trying to reserve
them results in messages like this, which are ugly but harmless:

    system 00:08: iomem range 0x0-0x0 could not be reserved

Future PNP patches will remove use of IORESOURCE_UNSET, but
we still need it for now.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>

Index: work11/drivers/pnp/system.c
===================================================================
--- work11.orig/drivers/pnp/system.c	2008-06-05 09:46:33.000000000 -0600
+++ work11/drivers/pnp/system.c	2008-06-05 10:29:10.000000000 -0600
@@ -81,7 +81,7 @@ static void reserve_resources_of_dev(str
 	}
 
 	for (i = 0; (res = pnp_get_resource(dev, IORESOURCE_MEM, i)); i++) {
-		if (res->flags & IORESOURCE_DISABLED)
+		if (res->flags & (IORESOURCE_UNSET | IORESOURCE_DISABLED))
 			continue;
 
 		reserve_range(dev, res->start, res->end, 0);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/