linux-kernel - Re: [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adatzg28sws.fsf@cisco.com>
Date:	Mon, 09 Jun 2008 09:38:59 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Stefan Roscher <ossrosch@...ux.vnet.ibm.com>
Cc:	Roland Dreier <rolandd@...co.com>,
	"OF-EWG" <ewg@...ts.openfabrics.org>,
	general@...ts.openfabrics.org, LKML <linux-kernel@...r.kernel.org>,
	"LinuxPPC-Dev" <linuxppc-dev@...abs.org>, hnguyen@...ibm.com,
	fenkes@...ibm.com, raisch@...ibm.com, TKLEIN@...ibm.com,
	THEMANN@...ibm.com
Subject: Re: [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts

 > +				if (desc->chip && desc->chip->eoi)
 > +					desc->chip->eoi(irq);

This doesn't seem like the type of thing a device driver should be
doing.  Both patches are rather short on changelog text -- what is the
issue here and how does this fix it?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/