linux-kernel - Re: [PATCH] x86: update mptable v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.55.0806092046090.26593@cliff.in.clinika.pl>
Date:	Mon, 9 Jun 2008 20:49:46 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Yinghai Lu <yhlu.kernel@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: update mptable v7 - fix

On Mon, 9 Jun 2008, Ingo Molnar wrote:

> here's the condition:
> 
> config X86_MPPARSE
>         def_bool y
>         depends on (X86_32 && (X86_LOCAL_APIC && !X86_VISWS)) || X86_64
> 
> 64-bit has it unconditionally, 32-bit has it on SMP, UP-IOAPIC or 
> UP-local-APIC mode. [ (and VISWS is an ugly complication we should try 
> to eradicate similarly to NUMAQ, if possible :-) ]

 Given X86_64 selects X86_LOCAL_APIC I am not sure the redundancy seen
above does not actually obscure the logic behind...  I think:

	depends on X86_LOCAL_APIC && !X86_VISWS

would be clearer and get the same.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/