[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1213045367.5026.66.camel@dax.rpnet.com>
Date: Mon, 09 Jun 2008 22:02:47 +0100
From: Richard Purdie <rpurdie@...ys.net>
To: Ben Dooks <ben-linux@...ff.org>
Cc: Linux ARM Kernel <linux-arm-kernel@...ts.arm.linux.org.uk>,
Linux Kernel <linux-kernel@...r.kernel.org>,
Arnaud Patard <arnaud.patard@...-net.org>
Subject: Re: [patch 4/5] sparse: leds-h1940.c: make non-exported symbols
static
On Sat, 2008-06-07 at 16:36 +0100, Ben Dooks wrote:
> plain text document attachment (sparse-fix-h1940-leds.patch)
> We do not need to export any of the routines inside
> drivers/leds/leds-h1940.c, so make them all static to
> quieten the sparse output for this driver.
>
> Fixes the following sparse errors:
> drivers/leds/leds-h1940.c:26:6: warning: symbol 'h1940_greenled_set' was not declared. Should it be static?
> drivers/leds/leds-h1940.c:55:6: warning: symbol 'h1940_redled_set' was not declared. Should it be static?
> drivers/leds/leds-h1940.c:85:6: warning: symbol 'h1940_blueled_set' was not declared. Should it be static?
>
> CC: Richard Purdie <rpurdie@...ys.net>
> CC: Linux Kernel <linux-kernel@...r.kernel.org>
> CC: Arnaud Patard <arnaud.patard@...-net.org>
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
Queued in the LEDs tree, thanks.
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists