linux-kernel - Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaod6a70mq.fsf@cisco.com>
Date:	Mon, 09 Jun 2008 14:35:09 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	steiner@....com
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, mingo@...e.hu,
	tglx@...utronix.de, holt@....com, andrea@...ranet.com
Subject: Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes

 > +EXTRA_CFLAGS += -DDEBUG -Werror -Wall

Not sure if it's appropriate to set these flags for your driver...

 > +	---help---
 > +	This option enables basic support for the SGI UV GRU driver. If
 > +	you are not running on a SGI UV system, say N.

"...enables basic support for the SGI UV GRU."  And it would be a good
idea to include some info about what UV GRU does -- your 0/11
introduction mail had a good description that would be nice to have here
as well.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/