linux-kernel - Re: [PATCH 1/2] drivers/s390/char/tape

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1213000552.19343.15.camel@localhost>
Date:	Mon, 09 Jun 2008 10:35:52 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	heiko.carstens@...ibm.com, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers/s390/char/tape_3590.c: introduce missing
	kfree

On Sun, 2008-06-08 at 14:56 +0200, Julia Lawall wrote:
> diff -u -p a/drivers/s390/char/tape_3590.c
> b/drivers/s390/char/tape_3590.c
> --- a/drivers/s390/char/tape_3590.c
> +++ b/drivers/s390/char/tape_3590.c
> @@ -1598,7 +1598,7 @@ tape_3590_setup_device(struct tape_devic
>         rc = tape_3590_read_dev_chars(device, rdc_data);
>         if (rc) {
>                 DBF_LH(3, "Read device characteristics failed!\n");
> -               goto fail_kmalloc;
> +               goto fail_rdc_data;
>         }
>         rc = tape_std_assign(device);
>         if (rc)
> 

Nice catch! I'll add this to the git390 queue for 2.6.26.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/