linux-kernel - Re: [PATCH] resend Removes PID_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080610072214.56bd3506@infradead.org>
Date:	Tue, 10 Jun 2008 07:22:14 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	"Rakib Mullick" <rakib.mullick@...il.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] resend Removes PID_MAX_DEFAULT.

On Tue, 10 Jun 2008 13:50:26 +0600
"Rakib Mullick" <rakib.mullick@...il.com> wrote:

> This removes use of PID_MAX_DEFAULT. please reply.

Hi,

can I ask why?
can you explain what is wrong with the original? To me it's a bit weird
to move this from a central location to 2 other places....


> 
> Signed-off-by: Md. Rakib Hassan Mullick (rakib.mullick@...il.com)
> ---
> diff -upr linux-2.6.25-vanilla/include/linux/threads.h
> linux-2.6.25/include/linux/threads.h
> --- linux-2.6.25-vanilla/include/linux/threads.h	2008-04-17
> 08:49:44.000000000 +0600
> +++ linux-2.6.25/include/linux/threads.h	2008-06-07
> 18:46:29.000000000 +0600 @@ -22,15 +22,10 @@
>  #define MIN_THREADS_LEFT_FOR_ROOT 4
> 
>  /*
> - * This controls the default maximum pid allocated to a process
> - */
> -#define PID_MAX_DEFAULT (CONFIG_BASE_SMALL ? 0x1000 : 0x8000)
> -
> -/*
>   * A maximum of 4 million PIDs should be enough for a while.
>   * [NOTE: PID/TIDs are limited to 2^29 ~= 500+ million, see futex.h.]
>   */
>  #define PID_MAX_LIMIT (CONFIG_BASE_SMALL ? PAGE_SIZE * 8 : \
> -	(sizeof(long) > 4 ? 4 * 1024 * 1024 : PID_MAX_DEFAULT))
> +	(sizeof(long) > 4 ? 4 * 1024 * 1024 : (CONFIG_BASE_SMALL ?
> 0x1000 : 0x8000)))
> 
>  #endif
> diff -upr linux-2.6.25-vanilla/kernel/pid.c linux-2.6.25/kernel/pid.c
> --- linux-2.6.25-vanilla/kernel/pid.c	2008-04-17
> 08:49:44.000000000 +0600 +++ linux-2.6.25/kernel/pid.c
> 2008-06-07 18:46:25.000000000 +0600 @@ -42,7 +42,10 @@ static struct
> hlist_head *pid_hash; static int pidhash_shift;
>  struct pid init_struct_pid = INIT_STRUCT_PID;
> 
> -int pid_max = PID_MAX_DEFAULT;
> +/*
> + * This controls the default maximum pid allocated to a process
> + */
> +int pid_max = CONFIG_BASE_SMALL ? 0x1000 : 0x8000 ;
> 
>  #define RESERVED_PIDS		300
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/