linux-kernel - [2.6 patch] always enable FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080610160408.GB11685@cs181133002.pp.htv.fi>
Date:	Tue, 10 Jun 2008 19:04:08 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	linux-kernel@...r.kernel.org
Cc:	David Woodhouse <dwmw2@...radead.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [2.6 patch] always enable FW_LOADER unless EMBEDDED=y

James Bottomley recently discovered that we have 
{request,release}_firmware() dummies for the case of the actual 
functions not being available and has a fix for the bug that was 
actually causing build errors for built-in users with 
CONFIG_FW_LOADER=m.

But now missing selects on FW_LOADER are no longer visible at 
compile-time at all and can become runtime problems.

FW_LOADER is infrastructure with relatively small codesize we can 
safely enable for everyone, and only for people who really need small 
kernels (and can be expected to know what they are doing) it matters 
being able to disable it.

This patch therefore always sets FW_LOADER=y and allows users only to 
disable it with EMBEDDED=y.

As a bonus, we can then get rid of all "select FW_LOADER" plus the due 
to it required "depends on HOTPLUG" which removes some complexity from 
our Kconfig files.

Signed-off-by: Adrian Bunk <bunk@...nel.org>

---

This patch has been sent on:
- 2 Jun 2008

462ee1ceb263f523b6f4e3bd30a0f63810f05c67 diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index d7da109..629e255 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -27,8 +27,9 @@ config PREVENT_FIRMWARE_BUILD
 	  If unsure say Y here.

 config FW_LOADER
-	tristate "Userspace firmware loading support"
+	tristate "Userspace firmware loading support" if EMBEDDED
 	depends on HOTPLUG
+	default y
 	---help---
 	  This option is provided for the case where no in-kernel-tree modules
 	  require userspace firmware loading support, but a module built outside

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/