linux-kernel - Re: 2.6.25-rc6: CONFIG_USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806100933060.3101@woody.linux-foundation.org>
Date:	Tue, 10 Jun 2008 09:36:08 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Oliver Neukum <oliver@...kum.org>
cc:	Pavel Machek <pavel@...e.cz>, linux-usb@...r.kernel.org,
	Greg KH <gregkh@...e.de>,
	Alan Stern <stern@...land.harvard.edu>,
	Linus Torvalds <torvalds@...uxfoundation.org>,
	Andrew Morton <akpm@...uxfoundation.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on



On Tue, 10 Jun 2008, Linus Torvalds wrote:
> +
> +		intf = actconfig->interface[i];
> +		driver = to_usb_driver(intf->dev.driver);
> +		if (!driver)
> +			continue;

This is wrong. It should be

	if (!intf->dev.driver)
		continue;
	driver = to_usb_driver(intf->dev.driver);

because doing the check after the "to_usb_driver()" conversion is too 
late. I copied the bug from Oliver's version.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/