linux-kernel - Re: [bug, 2.6.26-rc4/rc5] sporadic bootup crashes in blk_lookup_devt()/prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080610030755.GC6796@suse.de>
Date:	Mon, 9 Jun 2008 20:07:55 -0700
From:	Greg KH <gregkh@...e.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Kay Sievers <kay.sievers@...y.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Neil Brown <neilb@...e.de>,
	Mariusz Kozlowski <m.kozlowski@...land.pl>,
	Dave Young <hidave.darkstar@...il.com>
Subject: Re: [bug, 2.6.26-rc4/rc5] sporadic bootup crashes in
	blk_lookup_devt()/prepare_namespace()

On Mon, Jun 09, 2008 at 08:58:18AM -0700, Linus Torvalds wrote:
> 
> 
> On Mon, 9 Jun 2008, Kay Sievers wrote:
> > 
> > I think we should keep the patch, as it fixed a different issue, and it
> > seems the bug was there even before the patch - the function was just
> > not called 3 times, so even more unlikely to trigger it.
> 
> No, before the patch we never did a "dev_to_disk()" on the device. We just 
> did
> 
> 	if (strcmp(dev->bus_id, name) == 0) {
> 		devt = dev->devt;
> 		break;
> 	}
> 
> and we simply didn't care if it was a disk or a partition - it would work 
> correctly for both.
> 
> Your patch made it simply not work for partitions at all (by dereferencing 
> an illegal address off them). My fix makes it ignore partitions entirely, 
> but I'm a bit nervous that there might be some setup that sets up *only* 
> partitions, not any base device at all. I guess that is unlikely, but it 
> worries me a bit.

Thanks for finding this, it looks correct to me.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/