linux-kernel - Re: blackfin drivers/net/smc91x.c build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0806101013w42b9028j5dfa38d654f3d05f@mail.gmail.com>
Date:	Tue, 10 Jun 2008 13:13:52 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Adrian Bunk" <bunk@...nel.org>
Cc:	"Bryan Wu" <cooloney@...nel.org>, "Jeff Garzik" <jeff@...zik.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: blackfin drivers/net/smc91x.c build error

On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
> On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
>> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
>> > drivers/net/smc91x.c fails as follows on blackfin:
>> > ...
>> >  CC      drivers/net/smc91x.o
>> > ...
>> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
>> > ...
>>
>> it's a known issue (been known for quite a long time actually).  Bryan
>> has brought this up in the past already.
>
> Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
> correct or how else should it be resolved?

Bryan is taking care of it ... it may just stay broken in favor of
waiting for the merge from the net tree.

> This issue is the only remaining problem preventing that all blackfin
> defconfigs will compile in 2.6.26...

not really true.  but otherwise, failures dont go unnoticed as we have
automated nightly builds for all the relevant trees.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/