[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1213119746.13882.15.camel@nimitz>
Date: Tue, 10 Jun 2008 10:42:26 -0700
From: Dave Hansen <dave@...ux.vnet.ibm.com>
To: Andrea Righi <righi.andrea@...il.com>
Cc: balbir@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
kosaki.motohiro@...fujitsu.com, containers@...ts.osdl.org,
menage@...gle.com, xemul@...nvz.org
Subject: Re: [RFC PATCH 3/5] mgmcg VM overcommit interface
On Tue, 2008-06-10 at 01:33 +0200, Andrea Righi wrote:
>
> + cgroup_unlock();
> +
> + count = sprintf(page, "CommitLimit: %8lu kB\n"
> + "Committed_AS: %8lu kB\n",
> + K(allowed), K(committed));
> + ret = simple_read_from_buffer(userbuf, nbytes, ppos, page, count);
> +out:
> + free_page((unsigned long)page);
> + return ret;
> +}
I know you're trying to make this look like meminfo, but it does butcher
the sysfs rules a bit. How about breaking it out into a couple of
files?
-- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists