linux-kernel - Re: [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806101224.19455.jbarnes@virtuousgeek.org>
Date:	Tue, 10 Jun 2008 12:24:18 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
Cc:	Alex Chiang <achiang@...com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Matthew Wilcox <matthew@....cx>,
	Andrew Morton <akpm@...ux-foundation.org>,
	kristen.c.accardi@...el.com, greg@...ah.com, lenb@...nel.org,
	pbadari@...ibm.com, linux-pci@...r.kernel.org,
	pcihpd-discuss@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4, v14] PCI, ACPI: Physical PCI slot objects

On Monday, June 09, 2008 8:12 pm Kenji Kaneshige wrote:
> >  drivers/pci/hotplug/pci_hotplug_core.c |   16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > Index: 20080610/drivers/pci/hotplug/pci_hotplug_core.c
> > ===================================================================
> > --- 20080610.orig/drivers/pci/hotplug/pci_hotplug_core.c
> > +++ 20080610/drivers/pci/hotplug/pci_hotplug_core.c
> > @@ -555,6 +555,7 @@ int pci_hp_register(struct hotplug_slot
> >  {
> >  	int result;
> >  	struct pci_slot *pci_slot;
> > +	struct hotplug_slot *tmp;
> >
> >  	if (slot == NULL)
> >  		return -ENODEV;
> > @@ -567,6 +568,21 @@ int pci_hp_register(struct hotplug_slot
> >  	}
> >
> >  	/*
> > +	 * Prevent registering multiple hotplug slots with the same name.
> > +	 */
> > +	spin_lock(&pci_hotplug_slot_list_lock);
> > +	list_for_each_entry(tmp, &pci_hotplug_slot_list, slot_list) {
> > +		pci_slot = tmp->pci_slot;
> > +		if (pci_slot->bus == bus && pci_slot->number == slot_nr)
> > +			continue;
> > +		if (!strcmp(tmp->name, slot->name)) {
> > +			spin_unlock(&pci_hotplug_slot_list_lock);
> > +			return -EEXIST;
> > +		}
> > +	}
> > +	spin_unlock(&pci_hotplug_slot_list_lock);
> > +
> > +	/*
> >  	 * No problems if we call this interface from both ACPI_PCI_SLOT
> >  	 * driver and call it here again. If we've already created the
> >  	 * pci_slot, the interface will simply bump the refcount.
>
> Please note that I made this patch against linux-next with your
> latest three patches applied.

I looked this over and it seems like it's already handled in Alex's latest 
patchset (v15); can you take a look and make sure, Kenji-san (see Alex's 
latest mail to you too).

I just need acks from you and Kristen before pushing this...

Thanks,
Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/