linux-kernel - Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080610221427.GA28607@frolo.macqel>
Date:	Wed, 11 Jun 2008 00:14:27 +0200
From:	Philippe De Muyter <phdm@...qel.be>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver/video/cirrusfb : Fix RAM address printk

On Tue, Jun 10, 2008 at 11:51:21PM +0200, Jiri Slaby wrote:
> On 06/10/2008 11:42 PM, Philippe De Muyter wrote:
>> Hello everybody,
>> In the cirrusfb driver, the RAM address printk has a superfluous 'x'
>> that could be interpreted as "don't care", while it is actually a typo.
>> Fix that.
>> Signed-off-by: Philippe De Muyter <phdm@...qel.be>
>> diff -r 184e1bb486cf drivers/video/cirrusfb.c
>> --- a/drivers/video/cirrusfb.c	Mon Jun  9 19:30:13 2008 -0700
>> +++ b/drivers/video/cirrusfb.c	Tue Jun 10 13:25:22 2008 +0200
>> @@ -2432,7 +2432,7 @@ static int cirrusfb_pci_register(struct  
>> 	info->screen_size = board_size;
>>  	cinfo->unmap = cirrusfb_pci_unmap;
>>  -	printk(KERN_INFO " RAM (%lu kB) at 0xx%lx, ",
>> +	printk(KERN_INFO " RAM (%lu kB) at 0x%lx, ",
>>  		info->screen_size >> 10, board_addr);
>
> Hmm, is there \n missing too?
>

No that would make the RAM adress orphan, but we must also remove KERN_INFO
in the printk below.

>>  	printk(KERN_INFO "Cirrus Logic chipset on PCI bus\n");
>>  	pci_set_drvdata(pdev, info);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/