lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080610102125.2816c9e3.sfr@canb.auug.org.au>
Date:	Tue, 10 Jun 2008 10:21:25 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	paulus@...ba.org, geert@...ux-m68k.org, zippel@...ux-m68k.org,
	linuxppc-dev@...abs.org, linux-m68k@...ts.linux-m68k.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] drivers/macintosh/: possible cleanups

Hi Adrian,

On Tue, 10 Jun 2008 01:23:12 +0300 Adrian Bunk <bunk@...nel.org> wrote:
>
> +++ b/drivers/macintosh/adbhid.c
> @@ -75,7 +75,7 @@ static struct notifier_block adbhid_adb_notifier = {
>  #define ADB_KEY_POWER_OLD	0x7e
>  #define ADB_KEY_POWER		0x7f
>  
> -u16 adb_to_linux_keycodes[128] = {
> +static u16 adb_to_linux_keycodes[128] = {

This could be const as well.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ