linux-kernel - Re: [patch] x86: microcode: Cosmetic changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080611170939.GA15146@redhat.com>
Date:	Wed, 11 Jun 2008 13:09:39 -0400
From:	Dave Jones <davej@...hat.com>
To:	Ben Castricum <lk0806@...castricum.nl>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [patch] x86: microcode: Cosmetic changes

On Tue, Jun 10, 2008 at 01:15:12PM +0200, Ben Castricum wrote:
 > @@ -805,6 +806,9 @@ static int __init microcode_init (void)
 >  {
 >  	int error;
 >  
 > +	printk(KERN_INFO
 > +		"IA-32 Microcode Update Driver: v" MICROCODE_VERSION " <tigran@...azian.fsnet.co.uk>\n");
 > +
 >  	error = microcode_dev_init();
 >  	if (error)
 >  		return error;
 > @@ -825,9 +829,6 @@ static int __init microcode_init (void)
 >  	}
 >  
 >  	register_hotcpu_notifier(&mc_cpu_notifier);
 > -
 > -	printk(KERN_INFO 
 > -		"IA-32 Microcode Update Driver: v" MICROCODE_VERSION " <tigran@...azian.fsnet.co.uk>\n");
 >  	return 0;

By doing this before the registration of the sysdev, we'll
now be printing this on machines that don't have the microcode
update facility.   Pointless spew, for no obvious gain imo.

[Why we go through so many hoops before we check if the CPU is
 capable is a mystery to me. It would make more sense to have
 that be the first thing that gets checked when this inits]

	Dave

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/