linux-kernel - Re: bug in jiffy time comparison macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87hcc0it01.fsf@saeurebad.de>
Date:	Wed, 11 Jun 2008 04:51:26 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	Ralph Campbell <ralph.campbell@...gic.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: bug in jiffy time comparison macros

Hi,

Ralph Campbell <ralph.campbell@...gic.com> writes:

> It may just be me :-) but this looks like a bug:
> In the current include/linux/jiffies.h:
>
> #define time_before(a,b)        time_after(b,a)
>
> Shouldn't this be:
>
> #define time_before(a,b)        time_after_eq(b,a)

Then it would be time_before_eq()..?

If a is before b, b must be after a.  If they might be equal, than from
both points of view.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/