linux-kernel - Re: [PATCH REPOST] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jun 2008 17:23:15 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Stefan Roscher <ossrosch@...ux.vnet.ibm.com>
Cc:	Roland Dreier <rolandd@...co.com>,
	Paul Mackerras <paulus@...ba.org>,
	LinuxPPC-Dev <linuxppc-dev@...abs.org>,
	LKML <linux-kernel@...r.kernel.org>,
	OF-EWG <ewg@...ts.openfabrics.org>,
	general@...ts.openfabrics.org, TKLEIN@...ibm.com,
	fenkes@...ibm.com, raisch@...ibm.com, THEMANN@...ibm.com
Subject: Re: [PATCH REPOST] IB/ehca: In case of lost interrupts, trigger
	EOI to reenable interrupts

On Tue, 2008-06-10 at 16:44 +0200, Stefan Roscher wrote:
> During corner case testing, we noticed that some versions of ehca 
> do not properly transition to interrupt done in special load situations.
> This can be resolved by periodically triggering EOI through H_EOI, 
> if eqes are pending.
> 
> Signed-off-by: Stefan Roscher <stefan.roscher@...ibm.com>

This patch is fine with me as long as the FW/HW people can confirm that
calling spurrious EOI's like that will not affect other interrupts.

The side effect of writing 0xff to the xirr should be irrelevant as long as
this is not done from within a HW interrupt handler (timer interrupts or
softirqs are fine).

Due to the already incestuous relationship between HCA and the hypervisor,
I don't mind having the H call directly in the driver.

So as long as the FW/HW people are ok with that workaround, then it has
my ack as well.

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
---



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/