linux-kernel - Re: [PATCH 3/5] mutex debug: add generic blocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1213276891.16459.14.camel@localhost.localdomain>
Date:	Thu, 12 Jun 2008 06:21:31 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, Ulrich Drepper <drepper@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH 3/5] mutex debug: add generic blocked_on usage


On Thu, 2008-06-12 at 07:25 +0200, Peter Zijlstra wrote:
> On Wed, 2008-06-11 at 13:49 -0700, Daniel Walker wrote:
> > plain text document attachment (blocked_on-mutex.patch)
> 
> > -#ifdef CONFIG_DEBUG_MUTEXES
> > -	/* mutex deadlock detection */
> > -	struct mutex_waiter *blocked_on;
> > -#endif
> > +	/*
> > +	 * Deadlock detection and priority inheritance handling,
> > +	 * and any other out of line mutex operations
> > +	 */
> > +	struct lock_waiter_state *blocked_on;
> 
> Now you grew task_struct unconditionally, how about
> 
> #if defined CONFIG_DEBUG_MUTEX || defined CONFIG_RT_MUTEXES || defined CONFIG_FUTEX
> 
> ?

Ok .. I didn't add it cause I wasn't convinced RT_MUTEXES was
optional .. There's a lot of PI futex related code that isn't ifdef'd
either..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/