linux-kernel - Re: CDC_PLAY_AUDIO check in cdrom_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080612184742.GQ20851@kernel.dk>
Date:	Thu, 12 Jun 2008 20:47:42 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Tejun Heo <htejun@...il.com>
Cc:	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: CDC_PLAY_AUDIO check in cdrom_count_tracks() and other oddities

On Thu, Jun 12 2008, Tejun Heo wrote:
> Hello, Jens.
> 
> I'm tracking down a bug where HAL doesn't mount media automatically.
> It turned out that CDROM_DISC_STATUS wasn't reporting correct disc
> type which was caused by CDC_PLAY_AUDIO check failure at the top of
> cdrom_count_tracks().
> 
> I've went through MMC-3 but couldn't find anything which associates
> play audio capability with READ_TOC.  READ_TOC was mandatory command,
> so according to MMC-3, there's no reason to avoid issuing READ_TOC on
> !CDC_PLAY_AUDIO.  Is there something I don't know?

That check predates me :-)

I can't imagine drives NOT having READ_TOC, so I don't think it's a
problem to remove the depedency on CDC_PLAY_AUDIO.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/