linux-kernel - Re: [PATCH] undo the brd.c part of ramfs-and-ram-disk-pages-are-unevictable.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jun 2008 15:00:57 -0400
From:	Lee Schermerhorn <Lee.Schermerhorn@...com>
To:	Rik van Riel <riel@...hat.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: [PATCH] undo the brd.c part of
	ramfs-and-ram-disk-pages-are-unevictable.patch

On Thu, 2008-06-12 at 13:53 -0400, Rik van Riel wrote:
> Undo the brd.c part of ramfs-and-ram-disk-pages-are-unevictable.patch.
> The brd pages do not live on the LRU at all, so there is no need to
> play these tricks.

Does this mean that these pages cannot be migrated?  E.g., to evacuate
memory for hotplug?  Looks like all paths to migrate_pages() construct a
list of pages to migrate by isolating them from the lru
[isolate_lru_page()].  Any pages not found in the lru are skipped.

Lee
> 
> Debugged-by: Nick Piggin <nickpiggin@...oo.com.au>
> Signed-off-by: Rik van Riel <riel@...hat.com>
> 
> ---
>  drivers/block/brd.c |   13 -------------
>  1 file changed, 13 deletions(-)
> 
> Index: linux-2.6.26-rc5-mm2/drivers/block/brd.c
> ===================================================================
> --- linux-2.6.26-rc5-mm2.orig/drivers/block/brd.c	2008-06-11 14:39:43.000000000 -0400
> +++ linux-2.6.26-rc5-mm2/drivers/block/brd.c	2008-06-12 13:49:18.000000000 -0400
> @@ -374,21 +374,8 @@ static int brd_ioctl(struct inode *inode
>  	return error;
>  }
>  
> -/*
> - * brd_open():
> - * Just mark the mapping as containing unevictable pages
> - */
> -static int brd_open(struct inode *inode, struct file *filp)
> -{
> -	struct address_space *mapping = inode->i_mapping;
> -
> -	mapping_set_unevictable(mapping);
> -	return 0;
> -}
> -
>  static struct block_device_operations brd_fops = {
>  	.owner =		THIS_MODULE,
> -	.open  =		brd_open,
>  	.ioctl =		brd_ioctl,
>  #ifdef CONFIG_BLK_DEV_XIP
>  	.direct_access =	brd_direct_access,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/