linux-kernel - Re: [GIT PATCH] ACPI patches for 2.6.26-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.1.10.0806112301570.12191@localhost.localdomain>
Date:	Wed, 11 Jun 2008 23:08:17 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org,
	Linux Power Management List <linux-pm@...ts.osdl.org>
Subject: Re: [GIT PATCH] ACPI patches for 2.6.26-rc5



> >  27 files changed, 255 insertions(+), 180 deletions(-)
> 
> Hmm. I get very different statistics:
> 
>  27 files changed, 434 insertions(+), 359 deletions(-)
> 
> You seem to use "git diff -w" to ignore whitespace changes, which explains 
> it, but please don't - it makes it harder to compare with expected 
> results, and it hides some changes entirely.
> 
> I do agree that using '-w' is often useful, but especially for the purpose 
> of letting people know what changed it kind of avoids the point by hiding 
> many things.

Yes, I've been using "-b" recently:

git diff -b -M --stat linus..$RELEASE

and if I remove the "-b", we match:

 27 files changed, 434 insertions(+), 359 deletions(-)

I have a vague memory of having a good reason to cut over to "-b"
a while back and noting that in my pull request, but if you prefer
no -b, no problem.

thanks,
-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/